Skip to content

Deprecate compiled statement continuations in jdbc #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Deprecate compiled statement continuations in jdbc #3659

merged 1 commit into from
Oct 15, 2025

Conversation

g31pranjal
Copy link
Member

@g31pranjal g31pranjal commented Oct 3, 2025 •
edited
Loading

The CONTINUATION_CONTAINS_COMPILED_STATEMENT usage was cut down to always being true in #3650. It was enforced to always be so in release 4.7.1.0 for JDBC connections which would fail queries explicitly marking it as false. Now, this PR removes the check and marks the proto field as deprecated.

@g31pranjal g31pranjal added the cleanup Non-breaking/stylistic code cleanup label Oct 3, 2025
@g31pranjal g31pranjal changed the title deprecate compiled statement continuations in jdbc Deprecate compiled statement continuations in jdbc Oct 6, 2025
alecgrieser
alecgrieser approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@alecgrieser alecgrieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It does seem like this should go into a new minor version, because of how the cross-version compatibility shakes out, but it otherwise seems fine

fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
static com.apple.foundationdb.relational.jdbc.grpc.v1.Options.Builder toProtobuf(@Nonnull Options options) throws SQLException {
final var builder = com.apple.foundationdb.relational.jdbc.grpc.v1.Options.newBuilder();
// Switched-on by default on JDBC driver until the option is deprecated and removed.
builder.setContinuationsContainCompiledStatements(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into minor version 4.8 as it's intended to work only with 4.7.1.0 and newer? It's fine if it does; we could even bump the minor version in this PR.

@g31pranjal g31pranjal added the DO NOT MERGE do not merge label Oct 13, 2025
@alecgrieser alecgrieser mentioned this pull request Oct 14, 2025
Merged
@g31pranjal g31pranjal added breaking change Changes that are not backwards compatible and removed DO NOT MERGE do not merge breaking change Changes that are not backwards compatible labels Oct 15, 2025
@g31pranjal g31pranjal merged commit 9776f36 into FoundationDB:main Oct 15, 2025
12 of 13 checks passed
@g31pranjal g31pranjal mentioned this pull request Oct 15, 2025
Merged
g31pranjal added a commit that referenced this pull request Oct 15, 2025
@g31pranjal
Update minor version to 4.8 (#3678)
c8698f1 
Update minor version to `4.8` in response to #3659 and #3671.

These two changes activate features that are only intended to work with
version 4.7 and newer, so running in mixed mode with older versions is
not advised.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecgrieser alecgrieser alecgrieser approved these changes

Assignees

No one assigned

Labels

cleanup Non-breaking/stylistic code cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@g31pranjal @alecgrieser